AlphaCanisMajoris
AlphaCanisMajoris
Hi . I use the TLA+ specifications to verify the correctness of the fix in this pr. It can avoid the issues of [ZOOKEEPER-3023](https://issues.apache.org/jira/browse/ZOOKEEPER-3023), [ZOOKEEPER-4394](https://issues.apache.org/jira/browse/ZOOKEEPER-4394), [ZOOKEEPER-4646](https://issues.apache.org/jira/browse/ZOOKEEPER-4646) and [ZOOKEEPER-4685](https://issues.apache.org/jira/browse/ZOOKEEPER-4685). Besides, I...
> This should be superceded by #2111. Both try to log diff entries synchronous before NEWLEADER ack and #2028 is similar. Additionally, #2111 should fix [ZOOKEEPER-4643](https://issues.apache.org/jira/browse/ZOOKEEPER-4643) also. That's cool. The...
When the follower processes the NEWLEADER message, it only persists and processes the txns that the leader asks it to COMMIT. This guarantees no loss of committed txns because the...
Analysis of #2111 and #1848: #2111 can avoid [ZOOKEEPER-4643](https://issues.apache.org/jira/browse/ZOOKEEPER-4643), but it cannot fix other issues like [ZOOKEEPER-4394](https://issues.apache.org/jira/browse/ZOOKEEPER-4394): the NullPointerException problem when the follower receives COMMIT after replying NEWLEADER ack in...
Add a test case: `Zab1_0Test#testNormalFollowerRun_ProcessCommitInSyncAfterAckNewLeader`. This checks the case when the follower receives PROPOSAL, NEWLEADER, COMMIT & UPTODATE in order during Learner.syncWithLeader().
> One curiosity: > > > We have leveraged the TLA+ specifications of ZooKeeper and verified the correctness of this fix. > > Who is 'we' ? We are a...
Hi, @kezhuw. thanks a lot for your careful review! I've updated the code fix in this pr. Could u please take some time to check the new commit and see...
Hi @eolivelli. Sorry for bother you, but would you mind take a look at this pr and consider merging it? This pr fixes a bunch of issues in follower's syncWithLeader()...
> I will setup some time to review it early next week. Hi @li4wang, thanks for your participation in reviewing this pr! Do you think it ok to merge this...
Hi @kezhuw. Really appreciate your careful review of this pr the other days! Would u mind take some time to check the pr and see if it could be merged...