Almog Baku

Results 154 comments of Almog Baku

I suggest changing the names only in the docs and comments. The problem is mostly when communicating, it's not a techy issue.

Why not just provide a handler that wraps your handler? Maybe I'm missing something here? If you want to keep the default handler, you can also do something like this:...

We use it here https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/leaderelection/leader_election.go#L55

TBH, I'm against this one. This is very tempting to add functionality such as this to your solution, but enabling it on production might cause a *sensitive information leakage*. I...

what about adding a build tag as a solution?

Exposing this setting using a build tag is like having a “remote debugger” - possible, but should be allowed implicitly and temporary on production mode

I don't mind writing a PR if this is an acceptable feature.

@camilamacedo86, the reason I'm asking is to know if there's an acceptance to the concept since it's a major chunk ;-) [Viper](https://github.com/spf13/viper) looks good. I haven't known this one :)

Hey, Since this is a design feature, let's try to agree upon the design before I'll jump to implementation. I see that the `ComponentConfig` was contributed by @pwittrock, are you...

@camilamacedo86 should we add it to go/v4 or also for go/v3?