Should the core.Events RBAC permissions be scaffold by default in config/rbac/leader_election_role.yaml

[camilamacedo86]

trafficstars

What do you want to happen?

For the leader election, we request permissions to core.Events. The idea of this task is to investigate if it is required or if adding the permission is a bug since it is not used/required by the default implementation.

See: https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v3/config/rbac/leader_election_role.yaml#L31-L37

Extra Labels

No response

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[camilamacedo86]

To check this out we can see the motivations for: https://github.com/kubernetes-sigs/kubebuilder/issues/1474

[camilamacedo86]

In the meeting today we discussed this one and would be nice if we:

• a) Check if we need or not to scaffold these permissions by default (for that we need to check the C+R code)
• b) Check if we have a doc to describe how to raise events (if not then, would be nice to track an issue for that)
• c) We might want to check the motivations of https://github.com/kubernetes-sigs/kubebuilder/issues/1474 to see if it should not be better addressed via docs instead.

[AlmogBaku]

We use it here https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/leaderelection/leader_election.go#L55

[camilamacedo86]

closing this one.