Allen-Webb
Allen-Webb
I can take care of the rebase.
I ended up having to move all the glib initialization out of the constructor into the D-Bus IPC server thread.
The change as is doesn't currently provide a way to offer the D-Bus interface on the session bus, it is system only. I don't believe that will be a problem,...
> So I'm not sure we'd want this tied in like this. I know this may increase complexity a bit, but I feel it may make more sense to have...
The failures appear to be unrelated to this change. Is there any action I need to take?
It looks like you can rely on absl_config.pc to provide the redundant CFLAGS, and strip them from everything else that requires absl_config.
Here is a patch we are considering using for ChromeOS: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/3630468/1/dev-cpp/abseil-cpp/files/abseil-cpp-20211102.0-fix-pkgconfig.patch
I am having issues with the files provided. Picking an arbitrary sublibrary absl_base: here is the output without my fix: ``` pkg-config --cflags absl_base -Wno-float-conversion -Wno-implicit-float-conversion -Wno-implicit-int-float-conversion -Wno-implicit-int-conversion -Wno-shorten-64-to-32 -Wno-sign-conversion...
I also think some kind of backtrace chaining through source errors is really needed for thiserror.
I agree there shouldn't be warning related flags in the pkg-config entries.