Alireza Jafari

Results 18 comments of Alireza Jafari

> Hello, thanks for your efforts. just tested it, and it returns users list empty. ![Screenshot_2024-07-03_00-25-03](https://private-user-images.githubusercontent.com/118110306/345197491-9c2067f2-6746-4f7f-8279-aec05f5e8b57.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA3ODcxNzIsIm5iZiI6MTcyMDc4Njg3MiwicGF0aCI6Ii8xMTgxMTAzMDYvMzQ1MTk3NDkxLTljMjA2N2YyLTY3NDYtNGY3Zi04Mjc5LWFlYzA1ZjVlOGI1Ny5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxMlQxMjIxMTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hNTFjYWI2ODIwZjM2MzZhYTkwNDQyNjEyNGFiYmIxMjg4ZDRlNDI2NmY5Mjk3MzQ5N2FmYzdjNTg5MDVkYTE0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.Uf6S39XMXBBmTKW676JDH5uFWBYL-6QAocPq3jjsA6U) Sounds to be fixed now. The join led to the exclusion of users who...

Easier than expected :) P.S. I didn't have time to test the notifications, but I don't see any reason for them not working.

> first of all can you explain we have 3 migration here ? all of these can be one migration Ok, I'm convinced. 3 is too much. I'll merge them...

Sounds like I'm late to the party. I just merged the migrations :/

Do we need to mark username(s) params as deprecated? Since they support multiple usernames (unlike search) I didn't touch them yet. Is a multi-username search functionality necessary?

> > Do we need to mark username(s) params as deprecated? Since they support multiple usernames (unlike search) I didn't touch them yet. Is a multi-username search functionality necessary? >...

> This options would be great if exist : set multiple input to search for (user1,user2,user3) set the owner(admin) name (search for the input only in users of specific admin)...

And I think the `username` and `admin` params' changes should be a separate PR.