Alireza Jafari
Alireza Jafari
Sorry, but just as a reminder, is there any problem with this PR?
I don't know much about this project's documentation and its changelog, could please give me some links or description to change them in the right way?
You're welcome. But how about the documentation?
As I see 19.2 is released last month. It seems I should add a 19.3 section and describe the changes there, right?
Sorry about the forced pushes. I know using them is not a great idea, but I somehow got used to them :)
Both comments are resolved. Is there any problem anymore?
Fixes #910
> nice pr but you returning all admin data in this case this can cause data leak , users can see there admin data with `"/sub/{token}/info" ` request we just...
And since the non-sudo admins have no access to other admins' users, there would not be any risk of data leak cause it's the data that they should/and already have...
Since I don't like the pieces of code I wrote in the last commit, I chose to explain the changes. I know there are much better ways to handle this,...