Alice R.
Alice R.
> lookup1_values After looking at [the spec](https://xiph.org/vorbis/doc/Vorbis_I_spec.html#x1-1210009.2.3): since this function just returns the largest integer value less than or equal to the `codebook_dimensions`th root of `codebook_entries`, it seems like it...
Two more minor errors output by UBSan: * Usage of a code length of 32 results in signed overflow at line 1699. Easily fixed with `1U = 2^31 cause a...
I've been fuzzing libmodplug to find bugs in #57 and, despite finding one bug in that, I've mostly found a lot of bugs elsewhere instead. Particularly, there is some pretty...
Many of the crash bugs and slow loads I've encountered fuzzing libmodplug so far are from the MIDI loader. This loader does not seem to have been written with stability...
This should be fixed via #66 / #67 and maybe #76.
Will review soon when I get a chance.
> Can we get this, #88, and #92 in please for portability? This patch fully replaces #88 I think, but otherwise yes, these ought to be merged ASAP. > Does...
Does `#pragma pack(1)` on the affected structs not already fix this? edit: seems whether or not this forces the compiler to emit unaligned access safe code might be target-dependent.
This looks OK, though I *think* this library still tries to target C++98. I would recommend C-style casts instead. (@Konstanty @sezero please correct me if I am wrong.)