Alice Lilith

Results 26 comments of Alice Lilith

> Thanks for the contribution! > > My main concern is that this could end up breaking some users if they don't store tls secrets as `kubernetes.io/tls` > > Also...

I think option 1 is preferable.

I agree that we need to address this now. It doesn't make sense to wait until a future CRD version bump with an unknown date when there are ways to...

Just a quick update: since `2.4` has already been released, these changes will re-target an upcoming `2.5` release to get these fixes into a 2.x release. We still hope to...

Perhaps a future consideration would be to create a HealthChecking CRD that defines a single set of config for HealthChecking that can be used as a default config for either...

> fixes [datawire/apro#2431](https://github.com/datawire/apro/issues/2431) and helps with [datawire/apro#2911](https://github.com/datawire/apro/issues/2911) ? @KatieLo For https://github.com/datawire/apro/issues/2431 Envoy's active healthchecking is not the same thing as Kubernetes healthchecking, but they sound like they would both resolve...

Of course I'll write some docs for this to explain the usage and whatnot when we decide it's good to merge :wink:

> @AliceProxy FYI I'm seeing this issue with the following conformance tests: > > #431 #432 #433 > > Please see these issues for additional details. :+1: The changes I...

@seunggs The commits from the PR that closed this issue were not part of the 3.3.0 release. You'll need to use version 3.4.0 to get the fix from these changes....