Olivier Halligon

icon indicating a website link http://alisoftware.github.io/ icon indicating an email [email protected]

icon company Freelance on iOS Tooling and DX icon location Rennes, France icon location iOS architect & Swift lover. OSS enthusiast.

Results 375 comments of Olivier Halligon

Buildkite logs redactor patterns are evaluated greedily, and short values still redacted

> Based on your job logs, I don't think you are manually calling buildkite-agent redactor add with env vars. Rather, you're using s3-secrets-hooks which is what is calling it. I...

Buildkite logs redactor patterns are evaluated greedily, and short values still redacted

> It seems reasonable that there is no name check or minimum length check in buildkite-agent redactor add or the Job API - if a customer wants to redact a...

Buildkite logs redactor patterns are evaluated greedily, and short values still redacted

Btw FYI, some more context to our specific use case to explain why we set that `BUILDKITE_AGENT_PIPELINE_UPLOAD_REJECT_SECRETS` env var via `s3-secrets-helper` even if that variable value isn't really a secret...

Buildkite logs redactor patterns are evaluated greedily, and short values still redacted

@DrJosh9000 I took a stab at trying to fix this in https://github.com/buildkite/elastic-ci-stack-s3-secrets-hooks/pull/146 (Bear with me, this is my first time writing Go 😅 but I figured it was a good...

Bump minimum version of `aws-sdk-s3` dependency to `~> 1.197`

> [!NOTE] > CI failures in this PR that are about Ruby 2.x install failures will be fixed separately once https://github.com/fastlane/fastlane/pull/29734 lands.