Banana Duck comments

Results 10 comments of


                                            Banana Duck

Getting 401 unauthorized when passing token on multiple services

Hello, @yieniggu! I think it would be good to log an error. Then it will become clearer what the problem is)

Only log issue-845-fix if outpkg and inpackage are set

Hi @LandonTClipp! Can i take this issue?)

fix: unlock of unlocked mutex

> IMO this change could use a test, otherwise there's nothing preventing it from happen again. Is there any conventions or guidelines for writing test?

fix: unlock of unlocked mutex

@jesusvazquez thanks for the pointers. They are very helpful) Yeah, i'll write tests

fix: unlock of unlocked mutex

@jesusvazquez could you approve PR, please?

expfmt: throw error when metric's name not provided instead panicing

@roidelapluie could you review PR, please?)

expfmt: throw error when metric's name not provided instead panicing

> Hi, I would like to do a release of prom/common and this would be a nice fix to include, do you think you can add the test and fix...

expfmt: throw error when metric's name not provided instead panicing

@ywwg Could you merge PR, please?)

expfmt: throw error when metric's name not provided instead panicing

Hello! I would be glad if someone of you approved PR) @roidelapluie @gotjosh @ArthurSens

Mocks generated for constraint interfaces/anys

> This is probably the change that caused this: [#1074](https://github.com/vektra/mockery/pull/1074) > > Parsing happens in two steps: > > 1. Look for syntax that appears to be a type definition...