Alexis Montagne

@michaelklishin @streadway thanks for the feedback. I wanted to make sure the implementation would be ok with you. I will add some tests and documentation for the new public methods....

@michaelklishin sorry, i submitted my comment by mistake. I meant: In order to deal with canceled RPC calls. Should we close the channel? or keep it open? cf. https://github.com/streadway/amqp/pull/389/files#diff-861e77702f49a71d32be4b3c7600818fR185

@streadway you can find a standardized *amqp.Error here: https://github.com/streadway/amqp/pull/389/commits/95dafc3f19f4cdbda1fe2ba4b756dc00808258dd >> I meant: In order to deal with canceled RPC calls. Should we close the channel? or keep it open? >...

@streadway i updated the pull request according to your last message. And added a test to ensure the messages received after the call is canceled are dropped.

@streadway what do you think of https://github.com/streadway/amqp/pull/389#discussion_r261221451?

@streadway i think i got what you mean. Tell me what you think of that last commit. Are we really sure the server will always reply to the client? Will...

@streadway for some reason i was thinking a was mutex surrounding every `call()` calls 🤔 . I updated my PR to handle the use case you described (and added a...

@streadway it should be good now. I wrapped the "sending" part of the `call` method in a mutex. It also makes the frame sending thread safe. Previously https://github.com/streadway/amqp/blob/master/channel.go#L219 was not...

@michaelklishin i did not write any fo this documentation. I used the one already in the code for the context-free methods