Alexander Huszagh

Results 294 comments of Alexander Huszagh

@bluss The macro allows you to concisely initialize an arrayvec with a potentially larger backing store. Say I have the following type code: ```rust type StorageType = ArrayVec; pub fn...

I'm not sure we need the `fmt` changes since this library doesn't use `rustfmt`, but the `no_std` additions would be noce.

I've updated the PR to do the following: - Rename `parse_tokenized` to `parse_from_parts` - Significantly increase the amount of code sharing, rather than duplication, for simpler maintenance. This should be...

@aldanor Definitely. This might also be due to bad inlining. I'll try changing a few inlines to `#[inline(always)]`, to ensure they're identical to the code they're replacing, since 7% sounds...

Ok this is definitely slower and inling doesn't seem to work. Getting repeated ~7% performance hits with `canada.txt`, so I'll try to triage now.

> Thanks for testing out :) > > Yea, I've spent lots and lots of time (the majority other that correctness) in this crate trying to speed this up by...

It might be possible to use `#[inline(always)]` for everything, and undo this performance hit, but that seems like a bad strategy and lead to larger binary sizes (which would be...

I got similar results on x86_64 Windows MSVC (slightly more muted, but similar). I'm almost certain this is due to compiler inlining and weird stuff, and not actually going to...

@lemire Thanks for catching my typo....

@aldanor It would be removed from the Rust version, unless we have an RFC to add it. I can proposed a pre-RFC for this, however, on Rust-internals now. I'm also...