Alexander Chen
Alexander Chen
@aulorbe thanks again for the review, just pushed a commit which modifies the test cases; now there is one test case for when security scanning is enabled and benign documents...
> @Alexanderchen929 We'd also need an API key for the service to use in the tests. Thanks! @aulorbe @miararoy great point, what is the most secure way to supply you...
> > > @Alexanderchen929 We'd also need an API key for the service to use in the tests. Thanks! > > > > > > @aulorbe @miararoy great point, what...
> Thanks for sending over the secrets! Now that we have them, it'd be great if you wrote an integration test or two so that we can confirm everything works...
@miararoy Many thanks for the detailed review! Have addressed your comments in https://github.com/pinecone-io/canopy/pull/341/commits/87d8996fdf238293a4fcde075ff21dd232fada81. Please let me know if there are any suggestions!