Alex Waygood
Alex Waygood
> BTW, what is the etiquette around commits addressing review feedback that are not really meaningful changes by themselves? Should I squash them before the PR is merged? Please don't!...
Hi @marcelm — sorry for the delay in anybody looking at this. I haven't studied your PR in detail (or thought about whether the proposal is a good idea), but...
Cc. @larryhastings — may be of interest
Update on this: I tried this again in https://github.com/python/typeshed/pull/7635, and the number of pytype errors has gone down by quite a lot! This is the stack trace now: ``` stdlib/_compression.pyi...
Seems like we're all done here! We have our first recursive types successfully added to typeshed: #9134 Thanks @ilevkivskyi for all the incredible work on mypy recently to enable this!
> Fixed in [python/mypy#13482](https://github.com/python/mypy/pull/13482), so should be part of the next mypy release. Sadly, the mypy fix didn't *quite* make it into 0.981, so we'll have to wait a little...
> If we want to run primer on this with the mypy fix, let me know and I can run it ad hoc. That would be great!
> `__exit__` is expected to [return a bool](https://docs.python.org/3/reference/datamodel.html#object.__exit__) I think this is a slight misreading of the documentation that you link to here (the docs are admittedly quite subtle here,...
> For example if I wanted to implement something in a sub-sub-class of iobase that creates the context with ignoreBrokenPipe, or ignoreDroppedConnection parameter, I couldn't do that with `__exit__`. That...
> The contract for context manager's exit is a falsy/truthy return value, and IOBase is documented as being a context manager. But it is true that the vast majority of...