Alex Waygood

I would be tempted to land this as a standalone change before landing https://github.com/astral-sh/ruff/pull/22121, to make the ecosystem report on that PR easier to analyze. (IIUC, that PR adds a...

I think it's better to have a different error code here. `invalid-method-override` is specifically about Liskov violations, which this isn't. I've been wondering about renaming it to `unsound`-method-override, since there...

I think it would be good to give the error code a name that makes it clear it's specifically about dataclasses, though, which the documentation of the rule makes clear

Thank you! Sorry for the back-and-forth on naming... maybe `invalid-dataclass-override` might be good? - The name clearly indicates that it's dataclass-related - But it's a bit shorter than `unsound-dataclass-method-override` -...

Thanks for the report, and sorry our diagnostic here was so unhelpful! I think this _may_ be a duplicate of https://github.com/astral-sh/ty/issues/1644 and/or https://github.com/astral-sh/ty/issues/2154? Is either the superclass method or the...

Is it possible that you have two classes named `Product`, one in one file and one in another...? Do mypy and/or pyright complain about this override, or only ty?

> I think my suggestion to mark the incompatible part of the signature instead of the entire signature would still be helpful. Yes, I agree, and that's already tracked in...

> * Once in `datetime.py`: Go to def for the `_datetime` import doesn't work. I think this part, at least, is expected with our current capabilities because `_datetime` is a...

Looks like we're timing out on `meson` in the ecosystem CI jobs (might be worth rebasing on main to see if that magically fixes it??)

> Not sure how to tell whether there are any new mypy primer hits or if it's just the usual non-deterministic cases It might be worth seeing if you can...