Alex Li
Alex Li
Please don't hesitate to make breaking changes. I'll try adding a new class for redirects and adding `finalUri` too.
> > I'll try adding a new class for redirects and adding `finalUri` too. > > How about just for `finalUri`? That would be fine too, but I don't see...
Marking as ready for review again.
ping @brianquinlan
> 1. Are you sure that this is needed? Now that the final URL is available in `BaseResponse`, do we need a list of redirects? I believe we should definitely...
It should be a corresponding version of the GMS version. Is the dependabot be able to do this?
> Do the GMS and embedded versions track identically? If so, we can just replace "com.google.android.gms:play-services-cronet" with "org.chromium.net:cronet-embedded" in `prepare_for_embedded.dart` and leave the version unchanged. Unfortunately no
Well that is just my idea. I'll do some investigation about it, before that we can find the correct version and apply it first.
@brianquinlan Are you able contact owners of Cronet to know about version mapping between GMS and non-GMS versions? https://chromium.googlesource.com/chromium/src/+/refs/heads/main/components/cronet/OWNERS
There are not so many packages with Android implementation, only cronet_http for now.