Alex Hill comments

Results 33 comments of


                                            Alex Hill

transducers on write-ch receive formatted value

Ok yeah, let’s rule that breaking change out. A simple solution would be to deprecate those keywords and introduce :read-chan and :write-chan with the desired behaviour. Alternatively, one could pass...

transducers on write-ch receive formatted value

Yep, I can make a PR. So to summarise: I’ll add `:read-chan` and `:write-chan` options. These will be mutually exclusive with `:read-ch` and `:write-ch` - chord will throw if they’re...

Add timeout params to websocket client

Thanks for taking a look! I’m no longer in the job where I encountered this, but I believe making use of the new netty handshake is the right fix for...

Delay calling pushState() until the xhr succeeds

cc @josh

Delay calling pushState() until the xhr succeeds

Nice catch @Pym, fixed.

Delay calling pushState() until the xhr succeeds

@defunkt or @josh - any chance you could take a quick look at this PR? I'd like to get it in while it still merges cleanly.

Delay calling pushState() until the xhr succeeds

Paging @mislav - would really appreciate a glance over this change! All tests pass with this patch applied to latest master.

Delay calling pushState() until the xhr succeeds

Thanks for having a look at this! I'll try to make my case. > The changes seem plentiful I've renamed `locationReplace` to `hardLoad`, which creates a lot of noise in...

Delay calling pushState() until the xhr succeeds

Would you mind elaborating on that a little? The problem isn't clear to me. If you describe what this will break I will add a failing test and see if...