AlekseyTs

Should we optimize foreach over an ImmutableArray?

1

This is inspired by https://github.com/dotnet/roslyn/pull/61414#discussion_r1039023464. From @stephentoub: > There's less overhead to enumerating a span, as it's lowered to a for loop by Roslyn, that for loop is recognized by...

Championed issue: https://github.com/dotnet/csharplang/issues/2691 Speclet: https://github.com/dotnet/csharplang/blob/main/proposals/primary-constructors.md Feature branch: https://github.com/dotnet/roslyn/tree/features/PrimaryConstructors

See https://github.com/dotnet/csharplang/blob/main/proposals/params-collections.md#resolved-consider-enforcing-scoped-or-params-across-overrides

```diff namespace Microsoft.CodeAnalysis.Operations { /// /// Kinds of arguments. /// public enum ArgumentKind { /// /// Represents unknown argument kind. /// None = 0x0, /// /// Argument value is explicitly...

Championed proposal: https://github.com/dotnet/csharplang/issues/7700 Speclet: https://github.com/dotnet/csharplang/blob/main/proposals/params-collections.md Feature branch: https://github.com/dotnet/roslyn/tree/features/ParamsCollections - [x] LangVersion (`LanguageVersion_01_Declaration`, `LanguageVersion_02_CallSite`) - [x] Public API changes are approved - [x] https://github.com/dotnet/roslyn/issues/72222 - [x] https://github.com/dotnet/roslyn/issues/71816 - [x] Open ParamCollectionAttribute...

``` [Fact] public void Concat() { var source = """ using System; public class Test { static void Main() { var c = 'c'; Console.Write(M2(c)); } static string M2(char c)...

``` Public Async Function Test_IndexerWithNoRequiredParameters_02() As Task Dim input = using System.Collections.Generic; public interface I { int this[params IEnumerable<int> y] { get; } } CSharpAssembly1 Imports System.Collections.Generic Class C Implements...

``` [Fact] public async Task UnwrapParamsCollection() { var markup = """ using System; using System.Collections.Generic; class C { C(params IEnumerable a) { new C($$ } } """; await VerifyBuilderAsync(markup); }...

``` [Fact] public async Task TestWithParamsCollectionParameter() { var markup = """ using System.Collections.Generic; interface I { void M(params IEnumerable args); } class C : I { void I.$$ } """;...