Alasdair Armstrong

Oh, I rather got distracted by other things and forgot a bit about this issue - apologies. I came up with my own solution where I used the range combinator...

I made the suggested change so `signed1` is now `signed_rs1` and likewise for `signed2`, as well as rebased to the latest commit.

Do you have a description of the desired format you require?

Maybe the way to go would be to add a CSR attribute to the appropriate registers, then have Sail insert the logging statements. Would perhaps be less error prone than...

I mean if we know what registers are CSRs then rather than writing something like `print("CSR " ^ reg_name(...) ^ "

Are you planning on making a separate PR for the writes, or adjust this one? Otherwise LGTM, and we should get this fix in quickly.

> How was the original PR tested if we’re finding this now? We ran it on the tests in this repo, which I thought does include RV32 with virtual memory...

Is: ``` mapping clause assembly = C_LI_HINT(imm) "c.li" ^ spc() ^ "zero" ^ sep() ^ hex_bits_6(imm) ``` what you want?

I think this still falls into the nice-to-have category, but nobody every got around to implementing it.

Currently the exception 'handling' as it were is set up as below in the C code generator. When have_exception is true the current_exception variable points to a zexception struct. Right...