Alan Bateman
Alan Bateman
One thing to check is usages like `jnativescan foo`, should that fail as the tool doesn't take args? Another thing is that using joptsimple gives up a bit of control,...
`jnativescan --version` prints the value of Runtime.version where jdeprscan and some of the other tools print System.getProperty("java.version"). Just something to check as they might look inconsistent.
> I've massaged the parsing code to where the help message now looks like this: It is better but it might mean looking at HelpFormatter as you mentioned,. Right now...
> It looks like it's possible to get even more custom by using a custom `HelpFormatter` as well, if we wanted. I think what you have is okay for the...
Can you check if test/jdk/java/lang/module/ClassFileVersionsTest.java should be updated too?
Are you planning to add tests? I don't think we should be changing this code with good tests.
> Hi @AlanBateman and Kieran Farrell, > > do you mind having a look at this? The code patched by the original change in SocketChannelImpl.java is not in 17. Do...
Latest update to JvmtiMountTransition looks okay. I assume wait until Alex Menkov and Leonid are finished their reviews.
/reviewers 2 reviewer