Alan Bateman comments

Results 178 comments of


                                            Alan Bateman

8341903: Implementation of Scoped Values (Fourth Preview)

/csr

8341903: Implementation of Scoped Values (Fourth Preview)

The changes in update 90a344a3 looks okay, just one example in the ScopedValue docs that was missed (the example is correct in the loom repo).

8331341: secondary_super_cache does not scale well: C1 and interpreter

/label remove core-libs

8333796: Add missing serialization functionality to sun.reflect.ReflectionFactory

I skimmed through the latest update (d137f43) and I think you've got this to a good place and a sensible/workable proposal. I've asked from help from others on the security...

8191963: Path.equals() and File.equals() return true for two different files on Windows

> Just wondering how Windows implementation really behaves for its 'case-insensitive-comparing" for "\u0131 vs "I". I would assume they actually are 2 'distinguished" files? I think it depends on the...

8191963: Path.equals() and File.equals() return true for two different files on Windows

> For the purposes of this request, the equals methods operate on the string representation of the abstract pathname and do not interact with the file system. Exactly, so I...

8191963: Path.equals() and File.equals() return true for two different files on Windows

I think it is risky to change behavior after 20+ years. I think we got it right with WindowsPath but changing File means working through the compatibility impact and probably...

8191963: Path.equals() and File.equals() return true for two different files on Windows

> > [...] system property to restore long standing behavior. > > Added in [a63e13e](https://github.com/openjdk/jdk/commit/a63e13e1e086d299a4e1326606f3322a42cb5977). @naotoj, @xuemingshen-oracle, do you have any thoughts on the compatibility impact?

8328995: Launcher can't open jar files where the offset of the manifest is >4GB

/reviewers 2

8328995: Launcher can't open jar files where the offset of the manifest is >4GB

> Please keep this open, assistance on progressing this pull request is welcome ACK. There was a lengthy bug tail when zip64 support was added. We've got away without needing...