AkaHarshit

Results 7 comments of AkaHarshit

fix(fetch): align timeout errors with other adapters

Hi maintainers, This PR fixes the inconsistency where the fetch adapter ignored timeoutErrorMessage and always surfaced ETIMEDOUT, unlike the xhr and http adapters. What this PR does: 1)Extends composeSignals so...

fix: handle context option in roundToNearestMinutes when returning Invalid Date

Hi! Thanks for taking the time to review this PR. This update fixes an inconsistency in roundToNearestMinutes by ensuring the context option (options?.in) is respected when returning an Invalid Date,...

Fix app.render locals when options are null

Hi maintainers, This PR fixes a small regression introduced in the v5.1 app.render() spread merge logic. It restores the long-standing behavior where passing null or undefined options is equivalent to...

Fix app.render locals when options are null

Thanks for the review and feedback — really appreciate it! CC: @efekrskl @expressjs/collaborators — I’d welcome your further thoughts. To clarify the context — in Express versions 4.x and 5.0,...

Fix app.render locals when options are null

Thanks for the clarification, and noted on keeping replies short — will do. You’re right, Express 5.0.0 also throws. The behavior I was referring to was from Express 4.x (latest...

Fix app.render locals when options are null

Hi just checking in to see if there's anything more needed from my side. Happy to update the PR with any improvements or suggestions. Thanks!

Fix app.render locals when options are null

Hi just checking in to see if there's anything more needed from my side. Happy to update the PR with any improvements or suggestions. Thanks!