Arend Hummeling

Results 8 comments of Arend Hummeling

I would like to bring to your attention that the successful php8.0 and php8.1 tests seem to be false positives. https://github.com/Chris53897/datatables-bundle/runs/4731077536?check_suite_focus=true The tests are never executed, because simple-phpunit tries to...

Actually, considering this from [phpunit_bridge documentation](https://symfony.com/doc/current/components/phpunit_bridge.html#installation) > The PHPUnit bridge is designed to work with all maintained versions of Symfony components, even across different major versions of them. You should...

I think you might be confusing symfony's `FormType` with `DataTableType`. AFAIK, the `DataTableType` should not be used to create forms. (`createFromType` is not the same as `createFormType`). But apart from...

Oh sorry, I've misunderstood your question then. I understand what you mean, I'll leave a review.

From my understanding, this is already possible: ``` $table->add('field', TwigColumn::class)->setTemplate('tenant/students/snippets/overview/courses.html.twig', ['var' => 'value']); ``` However, I do agree that it is strange that the `TwigColumn` does not support this by...

> @Ahummeling that is NOT the same. that code runs `setTemplate` on the DataTable instance, not the column. It overrides the rendering of the entire table. Oh, I see. My...

Additionally, I'd be very happy to work on this issue and provide a PR. I just want to double check that I'm not seeing things that aren't really there

The changes proposed by the failing fabbot.io job are completely unrelated to my changes. ```shell curl https://fabbot.io/patch/symfony/symfony/54776/3d174a96ff253a877f81fe7216e1e72eae9d1d0e/cs.diff | patch -p0 ``` Perhaps this check was added after this file was...