Ahmad Saleem
Ahmad Saleem
Noticed that my PR got unintended changes to merge conflict or something else. Will try to do it later and will close this PR.
@smfr & @nikolaszimmermann - Can you guide or suggest on how to fix this 'ios-wk2' failure (svg/text/font-small-enlarged-minimum-larger.svg)?
> Thanks for tackling this -- not ready though, the LayoutTests changes seem fishy. Replied above and would appreciate your guidance because I am able to pass all changes by...
> That looks good - let's wait for EWS results. If ok, I'll r+ it. Thanks @Ahmad-S792 for your patience. No worries - I should appreciate you to deal with...
As discussed with @nikolaszimmermann over Slack, there is another change, which we require prior to landing this. So I will work on it and then have similar to this another...
Is this PR reverted the patch? [Link](https://github.com/WebKit/WebKit/pull/4348) since the bug seems to be closed, do we need to reopen bug to land this?
> What about the svg/text/... testcase in Blink which motivated the fix? Would be good to have another dedicated test to verify the behavior. **Background** - this Blink patch is...
@nikolaszimmermann - Is it something good to go or should I close this? Thanks!
> It’s fine to change this, but I don’t like the tactical choice. > > If we want to use `clampTo` we should change the call sites, not change the...
> We may want to accomplish the same thing by changing all the callers! ClampTo thing? - I can give it a go directory by directory, if you want like...