Jessica Chen

Results 30 comments of Jessica Chen

I'm planning on looking into it this weekend, at least for pokemon names. For the wiki, you would have to ask about that in one of the wiki channels in...

This has been started on #2312 which is just going to be the pokemon names for now while we work out any issues. Location names would be next, but we...

It will probably be better to wait for the translation system to be merged, and then you can use what we've already done to make sure your work is compatible.

The reason #275 was rejected (hover effect being lost when you are on the text) is no longer an issue with the new style of maps, however it doesn't work...

Do we also play the noise when the queue autohatches an egg? We should prevent it happening there too for the same "no user interaction required" reason.

Can we pull the debuff check out of getRandomLootTier and calculate that when opening the chest, so both getRandomLoot and getRandomLootTier are passed the same debuff flag? Just feels a...

Why are stone evo base pokemon and all evolutions of pokemon in the list also included in the TrainerEVList? If those pokemon weren't picked up by the gym and dungeon...

What's the motivation for caching calculatePokemonAttack? It only takes a few ms to run on my machine. Also I don't think it is a good candidate for caching - the...

Clicking shouldn't be calling calculatePokemonAttack directly, I think it's more likely you are one hitting pokemon and the tooltip is updating for the new pokemon types. The only other time...

Could you open an issue for the achievement thing? That one looks to me like you have it sorted by progress, so pretty much any action is triggering a recalc....