Admiral H. Curtiss
Admiral H. Curtiss
If you need to update curl, could you split that out into a separate PR and state your reasoning? (I guess our version could use a bump anyway...)
CMake with our External is still broken but I think this should fix the MSVC project?
I don't think using a pre-configured config header file for every platform is a good idea. For the Windows VS project, yeah sure, but for everything else it should just...
What exactly do we need from curl anyway, just HTTP/HTTPS?
I give up, this entire thing refuses to work properly (on Windows, anyway). Using the CMakeLists directly doesn't work (it fails to detect various headers and symbols that should be...
The hacky solution of just not using a config header on Windows seems to work, which makes no sense to me and I still hate the preconfigured header for the...
Alright, I already said this on Discord, but for posterity. I think this is terrible. A library as big and complicated as curl should *absolutely not* use a single preconfigured...
Well, no one spoke up against this, so let's hope this doesn't break compiling on half the linux distros...
I'm not sure if that's even exploitable with how we use curl in Dolphin but can't hurt, I suppose.
Good idea, but this definitely needs a bit more work IMO. I've only skimmed this, but here's a few notes: - An identical timestamp does not guarantee identical file data...