Adam Stone comments

Results 8 comments of


                                            Adam Stone

Should reject readAndCompressImage's promise when reader or img encounter error

@ericnograles can you comment on why #29 was never merged? These cases still fail silently and never resolve.

Is there any way to loadUrl() async?

I think the problem is is not with React, but [this `prepare` call](https://github.com/johnsonsu/react-native-sound-player/blob/8a684c9c361c833061d59fdb5a5cfb1fa57f11d2/android/src/main/java/com/johnsonsu/rnsoundplayer/RNSoundPlayerModule.java#L244) on the native side. Per the [docs](https://developer.android.com/reference/android/media/MediaPlayer#prepare()) this "prepares the player for playback, synchronously". For a remote...

[BUG]TypeError: "can't access property "playUrl", RNSoundPlayer is undefined"

Try rebuilding the native app (`npx react-native run-android`). RNSoundPlayer is a custom native module, so if you don't do a new native build after `npm install react-native-sound-player` the JS will...

Uncaught error in dropInstance onblocked handler

Not sure about the 'correct' behavior, maybe it's situational, but in my case I think I would want to leave it open and reject the drop request if the db...

Uncaught error in dropInstance onblocked handler

I made a [PR with this change](https://github.com/localForage/localForage/pull/807).

Uncaught error in dropInstance onblocked handler

@thgreasi Just checking back, any further thoughts on this?

Uncaught error in dropInstance onblocked handler

I updated the PR based on what I found in #821.

Uncaught error in dropInstance onblocked handler

Sorry, I sort of gave up on this after continuing to run into errors. Some additional changes may be necessary to accommodate this situation correctly. I tried a [couple](https://github.com/AdamStone/localForage/commit/8dbe9e6910d060d7485241df90e57cfbb62fc819) [more](https://github.com/AdamStone/localForage/commit/43bb9bdd0121d970ba9ff3554d5b920560bcbff2)...