Adam Wójcik

Results 1119 comments of Adam Wójcik

Merged manually 👍 Awesome work 👏👏 You Rock 🤩

> ### Validation failed! > File: [docs/docs/sample-scripts/spo/add-ci-cd-pipeline/assets/sample.json](https://github.com/pnp/cli-microsoft365/blob/8d93acf15422634ca59f75180af0d5f115d349f9/docs%2Fdocs%2Fsample-scripts%2Fspo%2Fadd-ci-cd-pipeline%2Fassets%2Fsample.json) > > * Invalid url for thumbnail [New command: list all available apps in the app catalog #1](https://github.com/pnp/cli-microsoft365/issues/1) property: The provided URL is...

> Since there's not much activity on the `pnp-sample-validation` repo, should we just remove the sample validation check? It doesn't work as intended and gives a misleading view in the...

> Awesome work on this one @Adam-it. A very extensive sample script. There's not much to add to it, only noticed some typos here and there. Nothing too major! Thanks,...

Seems solid 👍 some ideas I have are: - what if we also allow to specify site by name? and we solve to get the URL. if we find more...

also does this need to be an absolute URL? I think we support specifying just the relative path as CLI is aware of the host part of the URL right?

> > ``` > > * what if we also allow to specify site by name? and we solve to get the URL. if we find more than one site...

> > also does this need to be an absolute URL? I think we support specifying just the relative path as CLI is aware of the host part of the...

Good catch. We should definitely trim that

@pnp/cli-for-microsoft-365-maintainers anything I missed?