pnp
Adds a new sample script: setup CI/CD workflow. Closes: #5799
Validation failed!
File: docs/docs/sample-scripts/spo/add-ci-cd-pipeline/assets/sample.json
- Invalid url for thumbnail #1 property: The provided URL is not responding correctly!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Validation failed!
File: docs/docs/sample-scripts/spo/add-ci-cd-pipeline/assets/sample.json
- Invalid url for thumbnail New command: list all available apps in the app catalog #1 property: The provided URL is not responding correctly!
well ye as this is not merged yet 😉
A bit annoying that the validator fails because of this. So I logged an issue and hopefully, they can fix it 😄
https://github.com/pnp/pnp-sample-validation/issues/2
Yeah, we had the same issue at https://github.com/pnp/cli-microsoft365/pull/5842
Since there's not much activity on the pnp-sample-validation repo, should we just remove the sample validation check? It doesn't work as intended and gives a misleading view in the PR overview list when it fails. @pnp/cli-for-microsoft-365-maintainers, what do you think?
Fine for me to remove it. In my opinion, it doesn't add that much value.
Since there's not much activity on the
pnp-sample-validationrepo, should we just remove the sample validation check? It doesn't work as intended and gives a misleading view in the PR overview list when it fails. @pnp/cli-for-microsoft-365-maintainers, what do you think?
Validation failed!
File: docs/docs/sample-scripts/spo/add-ci-cd-pipeline/assets/sample.json
- Invalid url for thumbnail #1 property: The provided URL is not responding correctly!
Awesome work on this one @Adam-it. A very extensive sample script. There's not much to add to it, only noticed some typos here and there. Nothing too major!
Thanks, I applied your changes