Adam Wójcik

Results 1119 comments of Adam Wójcik

merged. This will be part of the next pre-release shortly and next minor release in a few weeks

I think it's only worth mentioning that the new code should follow the same approach as we have for already existing LM Tool that allows to add a page. https://github.com/pnp/vscode-viva/blob/main/src/chat/tools/spo/PageAdd.ts...

@Saurabh7019 I have nothing to add when it comes to the scope of this issue, but I believe if we just open it up there is little chance someone would...

uuuu looks interesting.... I will try to give it a check/review next week unless someone is quicker than me🤩

I think it's only worth mentioning that the new code should follow the same approach as we have for already existing LM Tool that allows to add a page. https://github.com/pnp/vscode-viva/blob/main/src/chat/tools/spo/PageAdd.ts...

@pnp/spfx-toolkit-maintainers I am wondering if this PR and functionality is actually needed. I am afraid it will create more confusion and I will try to explain why. In the past...

So I did some more testing of SPFx 1.22 and I think that `heft` is indeed needed. For example, one problem is that with just npm run build or package-solution...

@Saurabh7019 thanks for the comment. to tackle some of the things you suggested > this might not be a good idea. If SPFx 1.22 docs doesn't specifically recommend installing heft...

> > The PR which was merged a few weeks ago already introduced a tree view in tasks view having both gulp and npm scripts > > This is exactly...