Laura

Results 19 comments of Laura

I might pick up this PR and finish it. This is causing disruptions for my company.

This PR appears to break two tests, I will attempt to remedy this.

I think I've addressed the review items as well as passed the tests. Please fast forward this branch to https://github.com/AceCoderLaura/checkout/tree/finishing-628 if my changes are satisfactory.

Ah yes, my git configuration wasn't setup to convert line endings back to UNIX-style. I'll fix it some time today if I get some time.

I've pushed a version with only the changes to the TypeScript source files here: https://github.com/AceCoderLaura/checkout/tree/finishing-628-no-compile I will have to ask you to build the project yourself because I've run out...

I got some more time to work on this today and successfully transpiled the change to index.js without any disruptions to the line endings.

Yeah, just wasted a few hours of my time chasing shadows because of this. Probably not even the first time.

If you use a lowercase key in the Hashtable you can reference it with any casing from the template.

Definitely a feature worth having. I'm currently using environment variables for key-value pairs. It's a bit yuck but it works for my scenario. Would be good to do it properly...

Just tried it with 3.0.0 and the problem persists unfortunately.