OpenPBR

OpenPBR copied to clipboard

Add emission_weight

4

After some discussion internally (with @ZapAndersson), we feel that the emission controls would be improved if: - we add an `emission_weight` parameter in [0,1], that multiplies the luminance, defaulting to...

portsmouth

Remove provision for specular_weight to exceed 1

2

As discussed on [Slack](https://academysoftwarefdn.slack.com/archives/C06365EAQMP/p1721304580941849), the spec is currently inconsistent about the range of `specular_weight`. For dielectrics, we allow it to exceed 1, as a sort of convenience. For metals, we...

portsmouth

Move .html files to docs folder

2

Then GitHub pages needs to be pointed to the new `/docs` folder.

portsmouth

Specular weight > 1 can cause energy gain in metals, and NaNs in dielectrics

4

On testing we noticed that if `specular_weight > 1` and the material is metallic, then there is energy gain, e.g.: | `specular_weight` 1 | `specular_weight` 6 | | ------------- |...

portsmouth

Suggest Hoffman approximations for Fresnel factor of metal under coat/film

1

When metal is coated by a dielectric (or a thin film), its Fresnel factor will be modified due to the adjacent dielectric IOR differing from air. Modeling this in OpenPBR...

portsmouth

Give an explicit suggested formula for fuzz base-roughening

2

We describe in the spec a recommendation for implementing the roughening that a coat will generate in the underlying base lobes.  A similar effect should occur for _fuzz_ also...

portsmouth

Coat and Fuzz parameter order inconsistent between specification and reference implementation

2

Clearly a very minor detail, but the reference implementation has [Fuzz before Coat](https://github.com/AcademySoftwareFoundation/OpenPBR/blob/main/reference/open_pbr_surface.mtlx#L50) while the specification has [Coat before Fuzz](https://academysoftwarefoundation.github.io/OpenPBR/#parameterreference) in the parameter reference.

JGamache-autodesk

Proposal: Remove uifolder prefix from uiname strings

3

The current way of repeating the `uifolder` string in the `uiname` makes for a very repetitive UI experience:  Suggestion: remove the UI folder prefix to get instead 

JGamache-autodesk

Some minor rewording improvements/clarifications

4

Some minor changes are needed to improve the clarity of the wording (around the implementation of the coat details). I discovered these while using the spec myself to implement the...

portsmouth

Add footnote about colors being in-gamut (i.e. components in [0,1])

9

Based on the interesting discussion in https://github.com/AcademySoftwareFoundation/OpenPBR/issues/149, it seems worth adding this side note: 

portsmouth