Abe Jellinek
Abe Jellinek
Could you update the tests? Otherwise this looks good, thanks.
Oh, wait, this removes _all_ attachments. How about we remove all attachments if there are multiple but keep if there's only one ("Full Text PDF")?
Thanks! Do you have some `conference_proceeding` PNX we could use to add a test for this?
(I mostly just want to see how this affects what other fields are mapped to.)
@adam3smith: Sorry for the inactivity here lately! Yes, I am, although less than before. I think my main issue with this PR is that I'm not convinced of its usefulness...
OK, well, if we can add some examples of CSTR items with author info to this translator, that would be helpful. I also think the DOI fallback code should be...
OK, sounds good.
Fixed in d68b0aae3301255afad5fb68ec80f3e51940361f
> Could we please add this information as "en-US"? This doesn't seem worth adding a separate translator for unless we have other issues specific to this site to fix, unfortunately....
Thanks! Sorry for the delay in reviewing your changes. I'm happy with this and think it's ready to merge. Before we do that, though, is it OK if we use...