Aaron Stannard

Results 690 comments of Aaron Stannard

Gonna need to redo this - stuff like the framing code is phenomenally messy and difficult to reason about. That needs to be refactored and simplified first.

@to11mtm I'll get to this this week with an initial review, but looks promising

@to11mtm got it - benchmark it and let's see if it makes any difference. I'd probably prefer to just move everything to classes than having clever object pooling stuff that...

There is a setting that will do this for Akka.Cluster.Sharding already, have you tried setting this to `on` ? https://github.com/akkadotnet/akka.net/blob/f7ed2ac6c1baf88c8aacef8cc63a7c15de35d4fb/src/contrib/cluster/Akka.Cluster.Sharding/reference.conf#L239

I guess we could change that setting to accept a LOGLEVEL argument - that should do it

@LeonHartley so I implemented a fix for this in #7118 but decided not to merge it for 1.5.18 because it's kind of weird / sloppy. What I think we're going...

I'm now wondering if this was a bone-headed mistake on my part and this is just the `DivertTo` taking on the materialization value of the `Source`...

```text [INFO][01/19/2024 15:34:01.299Z][Thread 0017][PersistenceExtension (akka://test)] Auto-starting journal plugin `akka.persistence.journal.test` [INFO][01/19/2024 15:34:01.299Z][Thread 0017][PersistenceExtension (akka://test)] Auto-starting snapshot store `akka.persistence.snapshot-store.test` [INFO][01/19/2024 15:34:01.438Z][Thread 0012][akka://test/user/counter] Starting up [INFO][01/19/2024 15:34:06.494Z][Thread 0012][akka://test/user/counter] Received recover Akka.Persistence.RecoveryCompleted [INFO][01/19/2024 15:34:06.496Z][Thread...

Well this is puzzling, but reflects the problem using logging statements: ```text [INFO][01/23/2024 22:19:51.557Z][Thread 0017][PersistenceExtension (akka://test)] Auto-starting journal plugin `akka.persistence.journal.test` [INFO][01/23/2024 22:19:51.557Z][Thread 0017][PersistenceExtension (akka://test)] Auto-starting snapshot store `akka.persistence.snapshot-store.test` [INFO][01/23/2024 22:19:51.592Z][Thread...