Aaron Stannard
Aaron Stannard
When that same test passes, the logs look like this: ```text [INFO][01/24/2024 00:02:36.465Z][Thread 0010][PersistenceExtension (akka://test)] Auto-starting journal plugin `akka.persistence.journal.test` [INFO][01/24/2024 00:02:36.484Z][Thread 0010][PersistenceExtension (akka://test)] Auto-starting snapshot store `akka.persistence.snapshot-store.test` [INFO][01/24/2024 00:02:36.536Z][Thread 0031][akka://test/system/akka.persistence.journal.test]...
`Akka.Persistence.TestKit.Tests.Bug4762FixSpec.TestJournal_PersistAll_should_only_count_each_event_exceptions_once` is still failing with ```text [INFO][01/24/2024 02:01:24.467Z][Thread 0016][PersistenceExtension (akka://test)] Auto-starting journal plugin `akka.persistence.journal.test` [INFO][01/24/2024 02:01:24.467Z][Thread 0016][PersistenceExtension (akka://test)] Auto-starting snapshot store `akka.persistence.snapshot-store.test` [INFO][01/24/2024 02:01:24.565Z][Thread 0025][akka://test/system/akka.persistence.journal.test] Using write interceptor Noop [ERROR][01/24/2024...
So what is blocking the `TestSnapshotStore` from running in this case? Why does it only begin recovery as the `ActorSystem` is shutting down in these racy failure cases?
> Changing the actor dispatcher to "akka.actor.internal-dispatcher" eliminates the start-up delay, could it be that there's something wrong inside "akka.actor.default-dispatcher" implementation? We implemented this in #7117 - let's see how...
@Arkatufus looks to me like the dispatcher changes didn't have any impact
Thanks for this @yanpitangui - I'll take a look at this
> One thing that we should look at is the accessibility of the generated classes, right now everything is public. Changing everything to internal also break things, so I would...
``` D:\a\1\s\src\contrib\cluster\Akka.Cluster.Metrics\obj\Release\netstandard2.0\Serialization\Proto\ClusterMetricsMessages.cs(685,17): error CS0111: Type 'NodeMetrics' already defines a member called 'Equals' with the same parameter types [D:\a\1\s\src\contrib\cluster\Akka.Cluster.Metrics\Akka.Cluster.Metrics.csproj::TargetFramework=netstandard2.0] D:\a\1\s\src\contrib\cluster\Akka.Cluster.Metrics\obj\Release\netstandard2.0\Serialization\Proto\ClusterMetricsMessages.cs(700,25): error CS0111: Type 'NodeMetrics' already defines a member called 'GetHashCode' with...
Ah, you're right those files _were_ edited. TIL. Ok. give that a shot with the `partial` class approach.
> > Ah, you're right those files _were_ edited. TIL. Ok. give that a shot with the `partial` class approach. > > Even though the classes are partial, as they...