Aaron ForgeFlow
Aaron ForgeFlow
Hi @rousseldenis what is the status of this PR? is the module still needed?
Looking at the commit history, procurement_mto_analytic was created from purchase_procurement_analytic, it was actually a module rename. I think now that renaming was not necessary at that time, but I don't...
> That's why I wanted to depends on procurement_purchase_analytic for duplicated code and keep both (we can do that in a further PR) as this will not break anything IMHO....
> @AaronHForgeFlow @Cedric-Pigeon @airlessproject > > Do we agree to remove duplicate code from procurement_mto_analytic (purchase.order.line and stock.rule) and add a depends there on this module ? Ok for me!
Hi @SilvioC2C , this PR was superseded here: https://github.com/OCA/account-invoicing/pull/1138 and the CI is fixed on that one. Now, you can choose between closing your PR and accept the supersede, or...
@DavidJForgeFlow comments attended :)
Yes, I can inherit from _stock_account_prepare_anglo_saxon_out_lines_vals but then I would need to do the same loop and and put all the ifs statements because the checks are the same. That...
Closing as not popular :cry:
Reopened until Odoo accepts a hook for better inheritance.
just created the PR to Odoo here: https://github.com/odoo/odoo/pull/98947 if that is merge this module is not needed. Also fixed the commit history in this PR, that was incorrect. @rvalyi HI!...