AZero13
AZero13
> Hadn’t heard this was the best practice. Can you point me toward documentation about why that’s important? https://developer.apple.com/library/archive/releasenotes/ObjectiveC/ModernizationObjC/AdoptingModernObjective-C/AdoptingModernObjective-C.html If we meant to call super, we should call super. Yes,...
> I wouldn't recommend making these changes. I understand the hesitation. Nevertheless, reading code is important, and I tried looking for the override of one of the methods because of...
> Hi @RSilicon, I did previously warn you [back in February 2023](https://github.com/WebKit/WebKit/pull/9329#issuecomment-1424641575) to stop closing old pull requests and opening duplicates. It looks like an attempt to hide previous review...
Yes, on iOS this gets the same exact values for the collator as it does on macOS. Not just current, but for all different values.
@mcatanzaro What do you think of this?
@mcatanzaro Do you know any Apple Reviewers who could?
/cherry-pick https://github.com/llvm/llvm-project/commit/9c8dd5e6f6bd93deb95de9642632223f54a18a11
/cherry-pick https://github.com/llvm/llvm-project/commit/fb394562a3cf3522ac17a1436234ef5b926636fb
Another note, it would be nice if we could merge cmps like cmp x1, #0, and cmn x1, #1 if the values tested for 100% overlap, but I don't know...
@arsenm What do you think of this?