Results 28 comments of Alex Ware

I got caught out by this issue today, this pr would be really helpful.

Was looking at 1., and it's possible to save in the correct form- but the array is prone to reordering after save. And fixing it is nontrivial. ![Kapture 2021-01-29 at...

https://github.com/guardian/grid/compare/aw-mk-people-power I fixed the saving here, and rolled back my ordering fix (which didn't work)

@itsibitzi what's needed from that big list to get this merged vs a new pr?

Probably worth adding prettier to eslint while we're at it.

Hi @PicoCreator Thanks so much for this test case.

I think we should review this before we reingest.

As an alternative, can I suggest that instrumentation be a pre-runtime step? Having all the instrumentations patched into node_modules where possible would really help with reliability- especially where bundlers are...

We've just hit this problem using opentelemetry with esbuild, it would be really helpful if the `protos` directory could be passed in as a parameter, so that we don't have...

I disagree that this is not a bug. Bundling is fairly common, and expecting libraries to support bundling is not entirely unreasonable. The request is not that it work out...