RG

Results 16 comments of RG

The initial idea behind both of these tags was to allow "placeholders" from different places, to be represented in ways not possible simply. You can use a double placeholder provided...

> I do think `MiniMessageAudience` should be an interface that directly extends Audience and calls through to the `Audience` methods. A default implementation could exist private to the package, so...

> However, I do worry about the actual use of this in practice. For example, Paper couldn't really use this as `sendMessage(String)` conflicts. I guess they could just do a...

> > Hmmm, I'm not really sure I like this idea. I think it is potentially _too_ generic to be useful. I envision this `MiniMessageAudience` being a wrapper, with methods...

> That already exists with `ComponentLike`. > > I think making this interface more generic (in supporting non-MM serializers) would result in loss of functionality without benefits that outweigh that...

Does anyone have any opinions on what the unit tests should check? Kinda lost on that

Not too sure how I did not get a notification for pending conflicts in this pull request and how I passed the check-style last time

Kind of conflicted on the usage of `List` instead of `HashMap` for loaded candidates. Using HashMap would help in matching of plugin ids when trying to search for the possible...

Something I noticed is that once you have completed part 1, the part 2 is not saved automatically to the puzzle file. Doing `cargo read ` after you have completed...

> Something I noticed is that once you have completed part 1, the part 2 is not saved automatically to the puzzle file. Doing `cargo read ` after you have...