Jack

Results 238 comments of Jack

> At this point, I can detect two mods trying to override the same audio file, logging a warning message before Northstar crashes; should I also prevent file override by...

> (progress tracked here: https://github.com/Alystrasz/NorthstarLauncher/tree/feat/audio-multioverride-detection) Also, it looks like you are using the json file name to determine collisions, are we sure that that's accurate? Is it two audio overrides...

> no, i no longer engage with that topic. my last words on that have been said. not really a discussion then is it?

@Alystrasz would this need a rework to check `packages` as well? We already have basic format requirements for `packages` already so maybe not but want your opinion

> To be clear, do clients already ignore disconnect? Normal clients do not ignore `disconnect`, but a malicious one very much could. Therefore using `disconnect` to disconnect a client is...

> The only thing I need to keep in mind then in that regard is to give modders a heads-up in case they somehow made a server-mod that sends `disconnect`...

> So I got around writing a quick Thunderstore scraper and based on my local dataset, the following mods at their latest version will be affected > > - Zanieon-Matchmaking_Mixtape_Menu-1.2.0...

Not a lot that we can do about the mods that override these files. Lets be honest, they aren't going to get updated. But yeah https://github.com/R2Northstar/NorthstarMods/pull/841 fixes the cases in...

we should move it to atlas

> One thing to consider is whether that might expose mods on the server that server hosters don't wanna have exposed, e.g. some custom anti-cheat, Spyglass (maybe?), etc... Spyglass is...