Jack

Results 238 comments of Jack

> What's the reason for imposing the `txt` file extension? To stop people from writing executable scripts like .bat files

> I do take issue with `.txt` being the default, the data being stored doesn't necessarily have to be plaintext. Literally how, safe IO works in strings from squirrel, so...

> despite that its not uncommon to use a string as a container for binary data. I'm not sure exactly how Squrirel, let alone the squirrel in the game, handles...

There should be better ways of achieving the same goal.

> cant the `{}` formatting be archived with `std::make_format_args` and `std::vformat` we are on cpp 20 anyways Yeah, this was just me porting the refactor over without any changes

> If i was working on refactoring logging now I'd probably have `Msg`, `DevMsg`, `Warning`, `Error`, `FatalError` functions where `DevMsg` would be stubbed in release. I definitely agree about the...

> So how do we approach this? Change `%s` back to `{}` before merge or merge first and then in a second PR revert back to `{}`? Id say changing...

> I'd so, stick with `%s` and then change it back later once we got primedev updated? I'm fine with whatever gets us further faster, even if that means having...

Man i wish i could compile locally right now instead of having to do everything inside github

> I believe the only public log reader is Spectre, which I'm already rewriting due to the code being bad, so I'll rewrite with this in mind. Logging the mods...