Alexander J. Pfleger

Results 58 comments of Alexander J. Pfleger

The current physmon tests take around 11-18 minutes. In the `trackfinding_ttbar_pu200` we spend around 75-135 seconds. I think, we could double the number of events from 3 to 6, but...

we could still have this with `double` instead of the `float`s, no?

Looks like https://github.com/acts-project/acts/pull/3975 covered already all cases from in here :)

I was also thinking about it, after I started. I think `ActsScalar` makes more sense and should be also compatible with our testing strategy.

Would need more rework after https://github.com/acts-project/acts/pull/3873 . Also upgrade to `double` is changing effects a bit. Maybe we could find a more structured approach to this.

It has a way to fix misused macros. As everything in ACTS, no changes are made without a proper PR. Since we don't have any cases of the macros anymore,...

@paulgessinger I wanted to recheck, but I feel, it is good now. The sonar complaint is on nesting, but I already removed 2 layers in that part, so I would...

I saw, we merged a revised version of this PR. Can this PR already be closed? :) - https://github.com/acts-project/acts/pull/4240