AmirHosein Rostami
AmirHosein Rostami
@sadrasabouri @sepandhaghighi Hey guys, let me know your comments on the suggested CLI. also if you have a better idea, please surely let me know, I'm a little bit worried...
@sadrasabouri Thank you for your comment, I will consider both.
Since it is too fine-grained edition, I think it is better to just have it in Python usage (and not in the CLI usage). By passing a dictionary that contains...
OK, I will do this. why not. Then the user is supposed to pass a JSON file. but using only one config file when reserving a batch of names right?...
Answer: Either one config file or per name config file.
@sadrasabouri Dear Sadra, please review my updates.
NaN-type support is also added. Also please listen to voices in telegram, I've explained what I've done to handle these cases: - KBinsDiscretizer - PowerTransformer - SplineTransformer - TargetEncoder -...
We will address the coverage issue in a separate PR. I will enhance code coverage to over 90%.
Dear Sadra, I've applied your suggestions, thank you so much for your detailed review. I really appreciate it. Please re-review again.
@sadrasabouri Thank you Sadra for applying Sepand's comments, I went through them one by one and it is great! @sepandhaghighi waiting for your final review sir.