Annemarie Apple
Annemarie Apple
Spec update LGTM
Looks nice!
Can you give me two hours? I want to review all the spec tickets that are now in review and make sure we're not missing anything before we merge this...
I've been searching and I still haven't been able to find @srl295 's final link checking of the spec in the tickets. The closest I have found is https://unicode-org.atlassian.net/issues/CLDR-18031 but...
This looks good to merge. We can always put in a follow on PR if needed if there are further changes after this initial update.
Will languages be able to re-order the extension and the core parts? Do we know if there are languages where for certain combinations the extension may appear on different sides...
Can we have a ticket about this? I agree it would be good to have a FAQ on what this repo is for.
@macchiati @pedberg-icu - I updated the eras based on https://github.com/unicode-org/cldr/pull/4679. Does this look correct to you?
@macchiati - I went through even more thoroughly and double checked the data. I had to extrapolate for en_TW from the existing date formats to the other numeric date formats....
Test is here: https://github.com/unicode-org/cldr/blob/58e2f6f7889304691066458bd370c74d6df94463/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestCheckCLDR.java#L503 Looks like there are inherited values in bs.xml for example: https://github.com/unicode-org/cldr/blob/58e2f6f7889304691066458bd370c74d6df94463/common/main/bs.xml#L2963 @sffc - maybe you need to remove all the values for that era across all...