cldr icon indicating copy to clipboard operation
cldr copied to clipboard

CLDR-17462 update ST status icons for clarity

Open srl295 opened this issue 1 year ago • 16 comments

CLDR-17462

  • [X] This PR completes the ticket.

ALLOW_MANY_COMMITS=true

image

image_360

srl295 avatar May 29 '24 22:05 srl295

Has this been pushed to staging for UI review?

macchiati avatar May 30 '24 16:05 macchiati

Has this been pushed to staging for UI review?

Yes and you reviewed it, i'm preparing another push incorporating your feedback (such as the word 'inherited')

srl295 avatar May 30 '24 16:05 srl295

how's this for inherited+provisional? image

srl295 avatar May 30 '24 16:05 srl295

@macchiati i've now updated staging to e39d2b80a8aa128491e26ef6ea340535d6b4951c

srl295 avatar May 30 '24 17:05 srl295

how's this for inherited+provisional? image

I think that is ok, if you have a narrow space between them. That will allow for narrower columns

macchiati avatar May 30 '24 17:05 macchiati

how's this for inherited+provisional? image

I think that is ok, if you have a narrow space between them. That will allow for narrower columns

maybe a NNBSP

srl295 avatar May 30 '24 17:05 srl295

how's this for inherited+provisional? image

I think that is ok, if you have a narrow space between them. That will allow for narrower columns

maybe a NNBSP

Chrome, right-aligned, nnbsp

image

srl295 avatar May 30 '24 17:05 srl295

I didn't mean NBSP. That will force all columns on the page to be wide if one of them is. I was thinking the reverse; adding a narrow space (aka thin space) to allow the two icons to be on different lines. Not a non-break one, a breaking one.

macchiati avatar May 30 '24 17:05 macchiati

I didn't mean NBSP. That will force all columns on the page to be wide if one of them is. I was thinking the reverse; adding a narrow space (aka thin space) to allow the two icons to be on different lines. Not a non-break one, a breaking one.

different lines could be hard to scan, it'll look like alternating content. Here's the result with ZWSP:

image

srl295 avatar May 30 '24 17:05 srl295

Hmmm. Ok, let's try with them on the same line, and we'll ask the TC about it. Note: that only happens when the item being inherited is provisional or worse, right? If it is Contributes or Accepted, we see just a regular ⬆️, right?

macchiati avatar May 30 '24 17:05 macchiati

I didn't mean NBSP. That will force all columns on the page to be wide if one of them is. I was thinking the reverse; adding a narrow space (aka thin space) to allow the two icons to be on different lines. Not a non-break one, a breaking one.

different lines could be hard to scan, it'll look like alternating content. Here's the result with ZWSP:

image

This looks OK to me, FWIW. I agree it's better than causing change in column width.

stenshamn avatar May 30 '24 17:05 stenshamn

Hmmm. Ok, let's try with them on the same line, and we'll ask the TC about it. Note: that only happens when the item being inherited is provisional or worse, right? If it is Contributes or Accepted, we see just a regular ⬆️, right?

If I'm reading the logic correctly… only unconfirmed or provisional adds the "inherited" ⬆️. Otherwise it will only show the approved, contributed, missing symbols.

I don't see a code path where it shows only the uparrow.

srl295 avatar May 30 '24 17:05 srl295

If that is the case, we don't need the ⬆️ at all, just the X.

People will be able to see in the winning cell (from the color) that it is inherited, and the X tells them that it isn't approved/contributed

On Thu, May 30, 2024 at 10:59 AM Steven R. Loomis @.***> wrote:

Hmmm. Ok, let's try with them on the same line, and we'll ask the TC about it. Note: that only happens when the item being inherited is provisional or worse, right? If it is Contributes or Accepted, we see just a regular ⬆️, right?

If I'm reading the logic correctly… only unconfirmed or provisional adds the "inherited" ⬆️. Otherwise it will only show the approved, contributed, missing symbols.

I don't see a code path where it shows only the uparrow.

— Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/3763#issuecomment-2140484452, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEMAYFZ2C4NLL5VDED63ZE5SHFAVCNFSM6AAAAABIPY5NRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBQGQ4DINBVGI . You are receiving this because you were mentioned.Message ID: @.***>

macchiati avatar May 30 '24 18:05 macchiati

If that is the case, we don't need the ⬆️ at all, just the X. People will be able to see in the winning cell (from the color) that it is inherited, and the X tells them that it isn't approved/contributed

That's fine, we can drop the inheritance marker symbol then. (Reference to its discussion: CLDR-11103 )

srl295 avatar May 30 '24 18:05 srl295

So, thoughts? drop the inheritance icon?

srl295 avatar May 30 '24 19:05 srl295

Let's leave it in for now, so we don't delay.

macchiati avatar May 30 '24 20:05 macchiati

@macchiati just to be really clear, you are approving

A: NNBSP e0a503e - this is the current code in the PR

(updated image)

image

B: https://github.com/unicode-org/cldr/commit/e39d2b80a8aa128491e26ef6ea340535d6b4951c what is currently on cldr-staging

image

C: (not committed) using a ZWSP instead of NNBSP

image

srl295 avatar May 30 '24 20:05 srl295

Let's leave it in for now, so we don't delay.

let me know A B or C and i'll accept the ticket and get ready to merge

srl295 avatar May 30 '24 20:05 srl295

Ok, if C: (not committed) using a ZWSP instead of NNBSP is ready to go, let's do that.

macchiati avatar May 30 '24 20:05 macchiati

@macchiati it's option C now

srl295 avatar May 30 '24 20:05 srl295

Looks nice!

AEApple avatar May 30 '24 20:05 AEApple