ADmad
ADmad
I think the changes to `RedisEngine` seem good, need to add/update the tests now.
Here's what Copilot suggested: ------------------------------------------------------------------ ```yml jobs: test: runs-on: ubuntu-latest services: redis-cluster: image: grokzen/redis-cluster:7.0.12 ports: - 7000:7000 - 7001:7001 - 7002:7002 - 7003:7003 - 7004:7004 - 7005:7005 options: >- --health-cmd...
> Should we close this in favor of https://github.com/cakephp/cakephp/pull/18722 ? Whoever gets the tests running for the cluster wins :slightly_smiling_face:
> ... its only missing the actions setup. That's why I meant by "..gets the tests running..". The PR opened earlier should be favored.
We are exploring the use of property hooks for entities but still haven't made a decision whether it would be available in v5. Adding this new feature while maintaining backwards...
> Conversion to so-called on-demand evaluation of image objects. This means that image objects are only loaded internally into the memory when they are actually needed. Before that, they are...
I am open to renaming the option (`preserveIndex` for e.g.) and/or prefixing it with underscore to indicate it's a special core option.
I thought of an alternative which would avoid requiring a query option. We keep the existing keys if the results array is not a list: ```diff diff --git a/src/ORM/Association/Loader/SelectLoader.php b/src/ORM/Association/Loader/SelectLoader.php...
For most cases no extra args are needed. For e.g. only need to remove the possibility of passing value of 3rd argument at 2nd position. It was a convenience no...
> It would be ideal to have rector rules to help with updating application and plugin logic for these changes. Summoning our rector champion @LordSimal 😄