ADmad

Results 347 comments of ADmad

Having a `getOrFail()` does sound interesting. Please open a separate issue for it so that it's easy to track and discuss.

Thank you for continuing to try out this feature. I see there are 4 `$entity->get()` in the marshaller which need to be addressed. Will make a PR soon.

I think we should do a new minor release with the new sniffs added to the `5.next` branch. We can revisit adding more in the future.

Can you give an e.g. of error message without file and line number? I already see them in the error messages in the log file, for e.g.: ``` warning: Could...

So you are directly using the PHP function instead of the Cake function `triggerWarning()` which already includes the file and line number. Your change will duplicate that info for calls...

This doesn't change the public API and making the log output consistent is more of a bigfix than a new feature.

Probably an oversight, v5 of the code-sniffer should be PHP 8.1+.

@dereuromark I see you have added a few more rules regarding trailing comma besides the one I added in #398. So if you want to get them into the next...

> 266 more files changed on the function signatures, not sure if we want to do this too That's fine, better to stay consistent about the trailing comma along all...

phpcs v4 beta1 is out. Hoping by the time it's stable it will have support for property hooks.