Qi
CI is not started 🤔, no idea about the reason yet.
@t-yuki Thanks for your contribution!
I'd like to go over the uring implementation (#7320) again before reviewing this PR, this is because I took too much time to understand the fix in #7436. After that,...
I'm reading this branch locally, would you mind fixing the clippy reports? ```bash RUSTFLAGS="--cfg tokio_uring" cargo +1.88 clippy --all --tests --all-features ```
> Does the clippy job need to be modified? I think we need to improve the clippy job to cover different combination of feature flags of `cfg`s, `cargo-hack` may help...
Thanks, @t-yuki, I agree with your analysis, and we welcome this fix from the community. Are you willing to open a pull request to fix it? Internal ticket: KAG-5447
I'm also not inclined to add this feature into tokio, This feature is more related to observability things, not the async runtime itself.
https://crates.io/crates/future-timing/0.1.0 There is a crate provides similar features. I closed this PR based on our discussion, thanks for your contribution.
@Darksonn Thanks for your detailed review! I think I underestimated the complexity and coupling of the I/O components, which made me difficult to realize some critical **downstream impacts**. I have...
@Darksonn Hi, I have corrected the reason in PR description, would you mind taking another look?