Qi comments

Results 145 comments of

Qi

`time::advance` panics on `Duration::MAX`

Hi @arctic-alpaca , could you explain why do you want to advance the time as far as possible.

Implement `TryFrom<std::process::Child>` for `tokio::process::Child`

Hi @schneems , are you still working on this PR?

tokio-uitls: from_parts() for FramedWrite and FramedRead

Thanks for the context! I'm considering deprecating the `tokio_util::codec::FramedParts::new`. What do you think? What should the new constructor be called? `new_parts`? `new2`? `new_v2`?

tokio-uitls: from_parts() for FramedWrite and FramedRead

> How about new_unchecked() ?! @martin-g The `_unchecked` suffix is usually for unsafe function.

Identify if code is within blocking or async context

This looks like a very rare use case. The `tokio::task::try_id` only tell us if we are in a tokio task which might be an async task, or a task spawned...

Identify if code is within blocking or async context

I don't remember we have such recommendation, but is [`tokio::runtime::Handle::try_current`] helpful? [`tokio::runtime::Handle::try_current`]: https://docs.rs/tokio/1.48.0/tokio/runtime/struct.Handle.html#method.try_current

Support Direct I/O (O_DIRECT) for I/O

The io-uring support is working in progress: . Is supporting io-uring helpful for your usecase?

Support Direct I/O (O_DIRECT) for I/O

> The tricky part of Direct I/O isn’t so much “how to open the file”, but “how to use it afterwards”. I agree, utilizing `O_DIRECT` requires more setups than cached...

#7168: Add tokio_test::sink_mock

Hi @barafael , any update about this PR? If you are no longer working on it, I'd like to close this PR.

io: document default `ReaderStream` capacity

Hi @Owez , are you still going to work on this improvement?