Thomas Germer

Results 140 comments of Thomas Germer

Possibly the same issue https://github.com/MarcoForte/FBA_Matting/issues/49#issuecomment-1027875080

A commit in December moved the file. This is the last version where the file still was in the same location: https://github.com/MarcoForte/closed-form-matting/blob/622a6b74f333cb6cf9d5458a16302ab8b605c69a/solve_foreground_background.py This is the new location: https://github.com/MarcoForte/closed-form-matting/blob/master/closed_form_matting/solve_foreground_background.py This related...

The distance transform is used to compute an approximate alpha matte based on the trimap. The first function which is used here goes to 0 at approximately a distance for...

I think the channels are distributed like this: * 3 channels: This is the input image (group normalized). * 6 channels: Some kind of approximate alpha matte computed from the...

Steam is also affected by this bug, but they seem to be using X11 directly instead of glfw: ``` ldd /usr/games/steam.real ``` ``` linux-gate.so.1 => (0xf7f43000) libX11.so.6 => /usr/lib/i386-linux-gnu/libX11.so.6 (0xf7b3a000)...

We switched back to JIT compilation today because ahead-of-time compilation caused too many issues. Could you give it a try? ```bash pip3 install --upgrade pymatting ```

The only place where I could imagine that division by zero errors could occur is when dividing by the determinant here: https://github.com/pymatting/pymatting/blob/e5b1e86338ccf36a68904a9ace3eb4ddbc7fb29a/pymatting_aot/estimate_foreground_ml.py#L137 A positive regularization value should in theory ensure...

The alpha mask should be of shape `(h, w)` instead of `(h, w, 1)`. Replace ```python mask=imageio.imread('mask.png')[:,:,:1]/255 ``` with ```python mask=imageio.imread('mask.png')[:,:,0].copy()/255 ``` and it should work fine. Apparently, Numba simply...

Sorry about that. This was definitely a mistake in the documentation. Should be fixed now. We could of course do all kinds of checks to see whether the passed arguments...

Type hints might also be a good additional measure to issues like this. Unfortunately, NumPy does not yet support shapes, only `dtype`. I'll leave these issues here so it is...